Proposal: Membership System 2.1

#25

A little digging shows that setting the user title automatically per group doesn’t really work when you’ve got multiple groups fighting for “Primary” status. For example, my title reads Director, but click it and you get the Members group.

Therefore, I suggest adding an extra bit of code in MS2.1 that sets “Primary Group” with a definable hierarchy of primacy (eg. Director > Keyholder > Member)

The relevant API call should go like:

PUT d= primary_group_id=[group_id] https://discourse.southlondonmakerspace.org/admin/users/[user_id]/primary_group.json

(untested. it might accept username as well as id)

#26

The system actually already did this but Tom has been tinkering and changed things… I would suggest we make it explicitly say Keyholder rather than Member :key: or Member (keyholder)… You have to be a member to be a keyholder…

#27

Does that actually fix the issue?

#28

Well the system was supposed to do this, but nobody actually got given the "Member :key: " title cos of the clash of Primary Groups.

I think to fully fix it, ie. have the correct title, and have it link to the correct group, you’d have to drive Primary Group and User Title with the API.

#29

Further thought: we should probably only advertise who are keyholders to people logged in as members.

#30

Hmm, interesting, I hadn’t considered this as a thing, but makes some sense.

#31

I don’t think that’s possible

#32

Thats not possible, and most members become Keyholders so it’s not a big deal.

#33

Have done some more work tonight:

  • Got the code loading sub apps and the navbar sorted, this is substantially faster now, not that it matters, no will notice as it only loads apps once when the server starts.

  • Navbar updated to use dropdowns, this is probably most useful for administrators because there is no need to first click admin then members/permissions/transactions, you can just go direct to the app.

  • Rejigged the setup screen into it’s own app and put up a nag banner that won’t go away unless you setup your account properly.

  • An avatar link is also included, that directs users where to update their photo on Gravatar.com

Screen Shot 2016-10-08 at 23.29.40.png612×564 26.1 KB

Screen Shot 2016-10-08 at 23.45.13.png2310×824 73.8 KB

2 Likes
#34

More good work!

1 Like
#35

I’ve added a basic event feature as a starting point, for now it only logs actions to the API but I might add support for displaying other stuff like the door/shutter being open closed, and temperature logging, the code is there for that it just needs an API and someone to make the things in the space do that.

Screen Shot 2016-10-09 at 14.52.14.png880×344 20.6 KB

I also thought about adding a way of claiming a tag, but I’ve not got that far… this is just a basic log for now, not even paginated.

1 Like
#36

Discourse should pick up the gravatar and use it in place of the coloured letters, too.

#37

It does, but it’s not automatic, you have to select it and also use the reload icon if it is cached already…

Screen Shot 2016-10-09 at 16.32.29.png1488×694 68.2 KB

#38

I’ve written a script that runs once an hour (less frequently than permissions) to update the primary group of everyone.

It prioritises permissions in the database 1, 2, 3… and assigns the first permission they actually have as the primary group for the user, it doesn’t do this for users without any active permissions that haven’t got a order value, so in other words, if you aren’t a member, keyholder or director this won’t change and it doesn’t clear incorrect values for unlinked users.

Basically it should work, but it’s not, because Discourse still isn’t updating the user title.

#39

I am giving up on this, I’ve gone well beyond what I should have to do in order to get Discourse to behave correctly, this is a bug.

  • I’ve tried just setting the correct primary group.

  • Clearing the title and setting the group.

  • Clearing the group and setting the group again.

None of this works, and even using the UI it is next to impossible to get it to work properly, might be easier to just set the title in the membership system, but their code is the problem.

#40

I’ve done a last few tweaks for this burst of energy:

  • Made the mandate and subscription links in the admin area direct link into GoCardless so you can get more information.

  • Displays the permission you are filtering by in the member app.

  • Reduced how often it checks primary group to 6 hours, as this doesn’t work how we want and it is pretty hard on discourse.

  • Ordered all member lists in admin and public by last name, first name.

Also, the event app now has some real data because people have been using the door:

Screen Shot 2016-10-09 at 18.34.26.png780×590 39 KB

4 Likes
#41

Superb work as always :slight_smile:

1 Like
#42

A few updates, trying to make the Events app a bit more user friendly, especially as we end up with more events, it now shows only one month at a time…

Desktop:

Screen Shot 2016-10-12 at 22.21.30.png2346×1268 116 KB

Mobile:

Screen Shot 2016-10-12 at 22.21.02.png800×1334 68.2 KB

1 Like
#43

Could we have the Filter By Permissions dropdown in the Admin members list too please? Thank you :slight_smile:

#44

Admin > Permissions > (select the permission)

1 Like